bpf, selftests: Fix up some test_verifier cases for unprivileged
authorPiotr Krysiuk <piotras@gmail.com>
Tue, 16 Mar 2021 10:44:42 +0000 (11:44 +0100)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 19 Mar 2021 18:20:52 +0000 (18:20 +0000)
commit04e3dd4b3e984271eb89a2bfb61611bfa2802f5f
tree25b9f1907c20d7ab30e79a702ac14aef5f8cbb3d
parente45dd084b0d09611ff132846d713c5e2d98ccac5
bpf, selftests: Fix up some test_verifier cases for unprivileged

Origin: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit?id=0a13e3537ea67452d549a6a80da3776d6b7dedb3

Fix up test_verifier error messages for the case where the original error
message changed, or for the case where pointer alu errors differ between
privileged and unprivileged tests. Also, add alternative tests for keeping
coverage of the original verifier rejection error message (fp alu), and
newly reject map_ptr += rX where rX == 0 given we now forbid alu on these
types for unprivileged. All test_verifier cases pass after the change. The
test case fixups were kept separate to ease backporting of core changes.

Signed-off-by: Piotr Krysiuk <piotras@gmail.com>
Co-developed-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name bpf-selftests-Fix-up-some-test_verifier-cases-for-un.patch
tools/testing/selftests/bpf/verifier/bounds_deduction.c
tools/testing/selftests/bpf/verifier/map_ptr.c
tools/testing/selftests/bpf/verifier/unpriv.c
tools/testing/selftests/bpf/verifier/value_ptr_arith.c